Skip to content

fix: Use CaseTransform logging and simplify helper #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix: Use CaseTransform logging and simplify helper #169

merged 1 commit into from
Apr 1, 2025

Conversation

RyanSkraba
Copy link
Contributor

Just after the review yesterday, I noticed these two changes to propose (of course after I merged)!

  • Use the correct logger for this transform and
  • Remove an unnecessary parameter when modifying the struct.

@RyanSkraba RyanSkraba requested a review from a team as a code owner April 1, 2025 07:23
@RyanSkraba RyanSkraba requested review from jjaakola-aiven and removed request for a team April 1, 2025 07:23
jjaakola-aiven
jjaakola-aiven approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@jjaakola-aiven jjaakola-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@jjaakola-aiven jjaakola-aiven merged commit 23781fc into master Apr 1, 2025
4 checks passed
@jjaakola-aiven jjaakola-aiven deleted the rskraba/EC-54-typos branch April 1, 2025 07:31
@RyanSkraba RyanSkraba mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjaakola-aiven jjaakola-aiven jjaakola-aiven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanSkraba @jjaakola-aiven